Dedupe when returning all feature names #535
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccallum
changed the title
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
Closes #534
Visible Changes
For developers using a
IFeatureDefinitionProviderthat can return multipleFeatureDefinitionitems with the sameName, as is the case with the built-inMicrosoft.FeatureManagement.ConfigurationFeatureDefinitionProvider(which sources from the MS schema and the DotNet schema),FeatureManagement::GetFeatureNamesAsyncwill no longer return duplicates if a feature is configured multiple times (i.e. in each of those schema).This will help folks wanting to transition over gracefully, but could be considered a breaking change to current behaviour.
Note: Duplicate feature names in the one schema is already de-duped, as a test I added proved.